feat: oci-sif overlay digest sync #3120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
force-pushed
the
overlay-sync
branch
5 times, most recently
from
07b90ca to
f56c10d
Compare
dtrudg
changed the title
dtrudg
force-pushed
the
overlay-sync
branch
3 times, most recently
from
8c96ca6 to
1711a52
Compare
When a writable overlay is added to an OCI-SIF image, the digests for the ext3 layer in the OCI structures are correct. When the overlay is written to, its true digest no long matches those listed in the OCI structures, and recorded against the descriptor in the OCI-SIF. The new `singularity overlay sync` command will update the digests for an overlay, in an OCI-SIF file, that has been modified. It does this by: * Modifying the OCI.Blob digest recorded for the SIF descriptor. * Updating and re-writing the OCI image and index structures in the OCI-SIF. At this time, this sync task is only invoked by running `singularity overlay sync` manually. Future PRs may invoke the sync automatically prior to pushing the image to a remote destination. Closes sylabs#3119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
When a writable overlay is added to an OCI-SIF image, the digests for the ext3 layer in the OCI structures are correct.
When the overlay is written to, its true digest no long matches those listed in the OCI structures, and recorded against the descriptor in the OCI-SIF.
The new
singularity overlay synccommand will update the digests for an overlay, in an OCI-SIF file, that has been modified. It does this by:At this time, this sync task is only invoked by running
singularity overlay syncmanually. Future PRs may invoke the sync automatically prior to pushing the image to a remote destination.This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).