Skip to content

feat: push --layer-format tar #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024
Merged

feat: push --layer-format tar #2982

merged 1 commit into from
Jun 14, 2024

Conversation

dtrudg
Copy link
Member

@dtrudg dtrudg commented Jun 10, 2024

Description of the Pull Request (PR):

Add a --layer-format flag for the singularity push command. This applies only to pushes of OCI-SIF images (including data containers).

When --layer-format is not set, or is set to squashfs then the OCI-SIF image is pushed with layers in squashfs format. These can only be used by Singularity.

When --layer-format is set to tar then the OCI-SIF image is pushed with its layers converted on-the-fly to TAR format. The resulting pushed image can be used by other OCI runtimes.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

@dtrudg dtrudg added this to the SingularityCE 4.2.0 milestone Jun 10, 2024
@dtrudg dtrudg self-assigned this Jun 10, 2024
@dtrudg dtrudg force-pushed the issue-2848 branch 6 times, most recently from 279a1f1 to f191ef8 Compare June 14, 2024 14:55
Add a `--layer-format` flag for the `singularity push` command. This
applies only to pushes of OCI-SIF images (including data containers).

When `--layer-format` is not set, or is set to `squashfs` then the
OCI-SIF image is pushed with layers in squashfs format. These can only
be used by Singularity.

When `--layer-format` is set to `tar` then the OCI-SIF image is pushed
with its layers converted on-the-fly to TAR format. The resulting pushed
image can be used by other OCI runtimes.

Closes sylabs#2848
@dtrudg dtrudg changed the title WIP: feat: push --layer-format tar feat: push --layer-format tar Jun 14, 2024
@dtrudg dtrudg marked this pull request as ready for review June 14, 2024 16:33
Copy link
Contributor

@wobito wobito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtrudg dtrudg merged commit 1248147 into sylabs:main Jun 14, 2024
@dtrudg dtrudg deleted the issue-2848 branch June 14, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push from OCI-SIF to OCI registries in native OCI tar layer format
2 participants