[keyboard-layout] Add ediff remapping #13674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smile13241324
requested changes
Jun 14, 2020
There was a problem hiding this comment.
Hi @iv-nn,
I have reviewed your PR and it looks good. I like your detailed explanation about the necessity of the hack and I agree currently there is no better way to do this.
I have noticed that you have not entered a new line to changelog.develop. Would you mind adding your change to the keyboard layout section? Its mentioned in conventions to do so but we currently don't enforce it but it just saves us maintainers some time if the PR authors include it in their PR.
Last but not least, welcome to the project :).
iv-nn
force-pushed
the
add-ediff-keyboard-layout
branch
from
b580fbe
to
ed899be
Compare
|
Done :) |
smile13241324
approved these changes
Jun 14, 2020
|
Thank you for contributing to spacemacs 💜, I have cherry picked your commit into develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ediffsupport to thekeyboard-layoutlayer.It works well using the bepo layout and should work with the other layouts but is untested with those.
ediff-mode-mapis only defined once ediff is started, that's why I usedediff-startup-hookinstead ofspacemacs|use-package-add-hookorwith-eval-after-loadas I read in this issue: noctuid/general.el#59 but there may be another way. I'm new to emacs and spacemacs and this is my first time writing elisp so I'm not entirely sure.See also this issue: emacs-evil/evil-collection#196 (comment)