Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to add support for SRV records as
host
for a target of network_exporterI've got it working by extracting target records of SRV record and adding them as separate targets for network_exporter.
few notes:
I had to transform hierarchical
Config
type to inherited in order to be able to callTargets
type directly. Without it this linetargets := c.Targets[:0]
was messing with original targets from config file during the for loopAnd, this is actually my first lines in GO, so I easily imagine that code may look ugly and not "go style". Feel free to correct me.
Let me know if you are interested in this functionality