Open
Conversation
|
+1 for this merge if it works. I'm continually seeing this crash occurring in my app using EZRecorder. I stumbled on the same SO post as well but I'm also not familiar with the framework at this level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As is in the current version, if you start and stop recording a few times in quick succession, you'll likely run into an EXC_BAD_ACCESS in AudioRingBuffer::getTimeBounds. These changes do some kind of locking magic with the output file and stop this from happening.
I've just ported these changes without fully understanding how things work. But they do now work as far as my limited testing shows.
Based on changes described at:
http://stackoverflow.com/questions/7961087/exc-bad-access-in-audioringbuffergettimebounds
alexbw/novocaine#35