[Security] Redact persisted secrets and harden controller file permissions - #378
Open
fettpl wants to merge 11 commits into
Open
[Security] Redact persisted secrets and harden controller file permissions#378fettpl wants to merge 11 commits into
fettpl wants to merge 11 commits into
Conversation
Author
|
@0xSero, maintainer update: #378 is the focused current- It redacts known credentials before every controller/engine sink, bounds owner-only persistence, disables raw Docker daemon logs in favor of redacted attach output, and preserves exact process ownership through proxy failure and cleanup. Full gates are green; controller coverage rises by 0.82 function points and 0.80 line points; the fresh P0/P1 review is READY. It depends on #370. Exact-head desktop packaging passed, while the supported stable installer stopped before mutation because no valid signing identity exists. A formal review request is attached to the PR. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Controller and engine output could reach raw persistence paths before API-level redaction, while sensitive files inherited ambient filesystem modes. Direct engines and Docker also needed a redaction boundary that preserved the real worker identity and cleanup authority without introducing a second competing process owner.
Solution design
--log-driver noneand an exactstart --attachstream through the same redaction boundary, so the daemon does not retain raw output while Local Studio keeps a bounded redacted diagnostic log.Security invariants
0700and files are0600on supported Unix filesystems, including repaired existing installs.Dependency
Depends on #370. Merge #370 first, then rebase this branch onto current
dev, resolve any conflicts, and rerun all gates, comparable coverage, independent exact-head review, and signing-aware desktop acceptance before merge.Validation
6f32fa36050226fd0be74f5808dfe46af8f095fa.npm run checkpassed: release 12/12, frontend 123/123, controller 119/119, and agent runtime 97/97.npm run test:integrationpassed: 97/97.desktop:distcompleted successfully.code has no resources but signature indicates they must be present;/Applications/Local Studio.appremained unchanged.GET /api/desktop-healthacceptance are not claimed.Closes #229
Maintainer review requested in the PR discussion.