-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow building with the system Lua #969
base: main
Are you sure you want to change the base?
Conversation
Is it possible to still keep each crate's |
I can try, but that would likely require setting |
122c5f8
to
5b58e92
Compare
|
5b58e92
to
fd0e456
Compare
fd0e456
to
045d13a
Compare
yazi-dds = { path = "../yazi-dds", version = "0.2.5" } | ||
yazi-plugin = { path = "../yazi-plugin", version = "0.2.5" } | ||
yazi-proxy = { path = "../yazi-proxy", version = "0.2.5" } | ||
yazi-dds = { path = "../yazi-dds", version = "0.2.5", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to add default-features = false
to yazi-core
? yazi-core
is not the entry point of the program, is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because that dependency would otherwise expect to have those features, and we cannot override that without making enabling that feature not the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo tree
seems unreliable for these tests, so I just eza -l target/release
and compare the sizes. Without this there is no size difference between the default and --no-default-features
, but with this there is a difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What command did you use for building?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo build
with and without --release
and with and without --no-default-features
6c0a482
to
f5598eb
Compare
4eec20b
to
ed6ae00
Compare
33d04f9
to
3fdbbfe
Compare
72571df
to
9483798
Compare
6b59636
to
6aced05
Compare
9ddaba4
to
ef1a31a
Compare
f2e33da
to
c65bdb3
Compare
As per #943 (comment)
I tried to use
default-features = false
in the deps ofyazi-fm
andyazi-cli
and havevendored-lua
to be default in the dependencies, but when I did that it would just build with vendored lua every time. This is the only method that I could get to actually work, sorry if it's not ideal. :(