feat: adapt for image preview in the Rio terminal #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxyazi
approved these changes
Sep 26, 2024
sxyazi
changed the title
|
Hey @raphamorim, I pushed a new commit 853f507. Could you review it and check if the way of detecting Rio is correct? Also, are there any other conditions we could add to detect Rio too, like special env variables starting with |
looks correct 👍 rio also injects TERM_PROGRAM as equal rio in the env by default |
|
Nice, merging now |
|
Thank you @sxyazi 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If possible would like to add Rio to the terminal list 🙏
Thank you for yazi :D