image.nvim doesn't work with allow-passthrough all

[davidarny]

What system are you running Yazi on?

macOS

What terminal are you running Yazi in?

kitty v.0.37.0

yazi --debug output

Yazi
    Version: 0.3.3 (Homebrew 2024-11-14)
    Debug  : false
    Triple : aarch64-apple-darwin (macos-aarch64)
    Rustc  : 1.82.0 (f6e511ee 2024-10-15)

Ya
    Version: 0.3.3 (Homebrew 2024-11-14)

Emulator
    Emulator.via_env: ("tmux-256color", "tmux")
    Emulator.via_csi: Ok(Kitty)
    Emulator.detect : Kitty

Adapter
    Adapter.matches: Kgp

Desktop
    XDG_SESSION_TYPE           : None
    WAYLAND_DISPLAY            : None
    DISPLAY                    : None
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

Variables
    SHELL           : Some("/bin/zsh")
    EDITOR          : Some("nvim")
    VISUAL          : None
    YAZI_FILE_ONE   : None
    YAZI_CONFIG_HOME: None
    YAZI_ZOXIDE_OPTS: None
    FZF_DEFAULT_OPTS: Some("   --highlight-line   --info=inline-right   --ansi   --layout=reverse   --border=none\n  --color=bg+:#283457   --color=bg:#16161e   --color=border:#27a1b9   --color=fg:#c0caf5   --color=gutter:#16161e   --color=header:#ff9e64   --color=hl+:#2ac3de   --color=hl:#2ac3de   --color=info:#545c7e   --color=marker:#ff007c   --color=pointer:#ff007c   --color=prompt:#2ac3de   --color=query:#c0caf5:regular   --color=scrollbar:#27a1b9   --color=separator:#ff9e64   --color=spinner:#ff007c    --highlight-line   --info=inline-right   --ansi   --layout=reverse   --border=none\n  --color=bg+:#283457   --color=bg:#16161e   --color=border:#27a1b9   --color=fg:#c0caf5   --color=gutter:#16161e   --color=header:#ff9e64   --color=hl+:#2ac3de   --color=hl:#2ac3de   --color=info:#545c7e   --color=marker:#ff007c   --color=pointer:#ff007c   --color=prompt:#2ac3de   --color=query:#c0caf5:regular   --color=scrollbar:#27a1b9   --color=separator:#ff9e64   --color=spinner:#ff007c ")

Text Opener
    default     : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-create: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-rename: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : true
    tmux version       : tmux 3.5a
    tmux build flags   : enable-sixel=Unknown
    ZELLIJ_SESSION_NAME: None
    Zellij version     : 0.41.1

Dependencies
    file             : 5.41
    ueberzugpp       : No such file or directory (os error 2)
    ffmpegthumbnailer: 2.2.3
    pdftoppm         : 24.11.0
    magick           : 7.1.1-40
    fzf              : 0.56.2
    fd               : 10.2.0
    fdfind           : No such file or directory (os error 2)
    rg               : 14.1.1
    chafa            : No such file or directory (os error 2)
    zoxide           : 0.9.6
    7z               : No such file or directory (os error 2)
    7zz              : 24.08
    jq               : 1.7.1

Clipboard
    wl-copy/paste: No such file or directory (os error 2) / No such file or directory (os error 2)
    xclip        : No such file or directory (os error 2)
    xsel         : No such file or directory (os error 2)


--------------------------------------------------
When reporting a bug, please also upload the `yazi.log` log file - only upload the most recent content by time.
You can find it in the "/Users/david_arutiunian/.local/state/yazi" directory.

Describe the question

Seems that PR breaks https://github.com/3rd/image.nvim neovim plugin, as it requires allow-passthrough to be set to on in tmux.

Anything else?

Here is a demo of what happens:

CleanShot.2024-11-15.at.13.58.31.mp4

Validations

• I have searched the existing discussions/issues

[sxyazi]

Why does image.nvim only work with allow-passthrough on and not with allow-passthrough all? I can't find anything about allow-passthrough all being disallowed or not supported in its documentation

[davidarny]

@sxyazi here is why https://github.com/3rd/image.nvim/blob/7f61c1940a8b072ca47a28928d2375dc1e11f464/lua/image/utils/tmux.lua#L6

Probably an issue in a plugin 🤷

[davidarny]

Opened an issue there as well 3rd/image.nvim#243

[sxyazi]

From the code, it looks like this issue is caused by image.nvim not correctly handling allow-passthrough all — it only accounts for the allow-passthrough on.

In this case, it would be best to fix it within image.nvim, because it's not just Yazi that sets allow-passthrough all; users may also set it manually in their tmux configuration.

Also, the doc for Yazi and doc for st-graphics recommends users to set it, meaning that even if Yazi doesn't set it, image.nvim still won't work if the user has already set it themselves.

[davidarny]

@sxyazi thanks for clarification!