Improve time step too small error. #6035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wthrowe
requested changes
May 29, 2024
src/Time/Actions/ChangeStepSize.hpp
Outdated
| << desired_step << " which, when divided by the slab size (" | ||
| << current_step.slab().duration().value() << ") is below the tolerance " | ||
| << smallest_relative_step_size << ". The current time is " | ||
| << (current_step.slab().start() + current_step).value() << "."); |
There was a problem hiding this comment.
Current time is time_step_id.substep_time() (a double).
There was a problem hiding this comment.
Done! Thanks for the review :)
nilsdeppe
force-pushed
the
better_stepper_size_error
branch
from
7a73177
to
1f60290
Compare
wthrowe
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
@deborahferguson got the error message with a CCE run and admittedly it wasn't super clear. I think this is somewhat of an improvement, but could still probably use some work. The tricky bit is that there are a lot of reasons why the code could go unstable and result in a tiny time step size :(
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments