Add CLI to plot basic control system quantities #5978
Conversation
| plt.title(title) | ||
| axes[1].legend(loc="center left", bbox_to_anchor=(1.01, 1.1)) |
There was a problem hiding this comment.
Opinions on how to better represent the shape components are welcome. Just did the easiest thing for now to quickly get it in.
There was a problem hiding this comment.
How about an L2 norm over all shape components
There was a problem hiding this comment.
I think it will be important to be able to distinguish which component is the one that's going bad, so I don't think lumping them together would be best.
There was a problem hiding this comment.
You could plot both the L2 norm and the highest mode then
There was a problem hiding this comment.
Or one plot where the components of each control system are lumped together so you have only one line each for expansion, rotation, shape, size. This tells you which control system is going bad. Plus one plot for each control system with all the components. This tells you which component is going bad. So you have a figure with 1+num_control_systems rows and 1 col.
There was a problem hiding this comment.
Maybe do L2 over each m for each l with an option to show all m modes for a specific l and nothing else?
There was a problem hiding this comment.
Having 1+num_control_systems plots sounds a bit crowded and also hard to compare between control systems. I do like doing the L2 over all m of a given l by default and then having an option to show all m.
|
@nilsdeppe Squashed and rebased |
|
Here are the updated plots without/with all of the m modes
|
Proposed changes
Example of output:
Upgrade instructions
To use, build the CLI then run
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments