Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop built-in LanguageClient, rely on the client provided by pygls #61

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

alcarney
Copy link
Member

This depends on a version of pygls that does not exist yet.

By using the LanguageClient provided by pygls we get to further simplify pytest-lsp's architecture.

  • The server process is an asyncio.subprocess.Process and managed by the event loop (Closes Investigate child watchers #59)
  • We no longer have to continuously probe the server process to see if it is still alive
  • We no longer have to use a thread pool to asynchronously read from the server's stdout

@alcarney alcarney merged commit 951e6ae into swyddfa:develop Jun 21, 2023
@alcarney alcarney deleted the pygls-client branch June 21, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate child watchers
1 participant