Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.2.0 release build failed #284

Closed
chenrui333 opened this issue Jul 15, 2024 · 2 comments · Fixed by #286
Closed

2.2.0 release build failed #284

chenrui333 opened this issue Jul 15, 2024 · 2 comments · Fixed by #286

Comments

@chenrui333
Copy link

👋 looks like 2.2.0 release build failed, raise this issue for awareness. Thanks!

relates to Homebrew/homebrew-core#177258
@swsnr
Copy link
Owner

swsnr commented Jul 15, 2024

I know, but I haven't found motivation to fix it. Does it affect Homebrew? I thought homebrew builds from source and doesn't use upstream binaries?

swsnr added a commit that referenced this issue Jul 28, 2024
@swsnr
Generate completions at runtime
5fdc757 
No longer generate completions at build time; instead add a new
--completions argument to allow generating completions at runtime.

This removes one set of artifacts written to $OUT_DIR, and thus goes one
step towards removing the OUT_DIR dependency from the whole release
process, which in turn fixes the release pipeline.

See GH-284
@swsnr swsnr mentioned this issue Jul 28, 2024
Merged
swsnr added a commit that referenced this issue Jul 28, 2024
@swsnr
Generate completions at runtime
21ff27d 
No longer generate completions at build time; instead add a new
--completions argument to allow generating completions at runtime.

This removes one set of artifacts written to $OUT_DIR, and thus goes one
step towards removing the OUT_DIR dependency from the whole release
process, which in turn fixes the release pipeline.

See GH-284
swsnr added a commit that referenced this issue Jul 28, 2024
@swsnr
Generate completions at runtime
6b0df7e 
No longer generate completions at build time; instead add a new
--completions argument to allow generating completions at runtime.

This removes one set of artifacts written to $OUT_DIR, and thus goes one
step towards removing the OUT_DIR dependency from the whole release
process, which in turn fixes the release pipeline.

See GH-284
swsnr added a commit that referenced this issue Jul 28, 2024
@swsnr
Generate completions at runtime
d2d1552 
No longer generate completions at build time; instead add a new
--completions argument to allow generating completions at runtime.

This removes one set of artifacts written to $OUT_DIR, and thus goes one
step towards removing the OUT_DIR dependency from the whole release
process, which in turn fixes the release pipeline.

See GH-284
swsnr added a commit that referenced this issue Jul 28, 2024
@swsnr
No longer build manpage in build scripts
5d94b5b 
Instead, build manpage only as part of the release process to include it
in the release artifacts, and document how to build it during packaing.

This finally removes the OUT_DIR dependency for the release pipeline,
which simplifies and fixes the release pipeline.

Closes GH-284
swsnr added a commit that referenced this issue Jul 28, 2024
@swsnr
Generate completions at runtime
23401ee 
No longer generate completions at build time; instead add a new
--completions argument to allow generating completions at runtime.

This removes one set of artifacts written to $OUT_DIR, and thus goes one
step towards removing the OUT_DIR dependency from the whole release
process, which in turn fixes the release pipeline.

See GH-284
swsnr added a commit that referenced this issue Jul 28, 2024
@swsnr
No longer build manpage in build scripts
c796cea 
Instead, build manpage only as part of the release process to include it
in the release artifacts, and document how to build it during packaing.

This finally removes the OUT_DIR dependency for the release pipeline,
which simplifies and fixes the release pipeline.

Closes GH-284
@chenrui333
Copy link
Author

chenrui333 commented Sep 14, 2024 •
edited
Loading

Thanks @swsnr!

relates to Homebrew/homebrew-core#190577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix release pipeline swsnr/mdcat
2 participants
@swsnr @chenrui333