Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with PHP 8.3 #5133

Merged
merged 5 commits into from
Sep 29, 2023
Merged

Fix compatibility with PHP 8.3 #5133

merged 5 commits into from
Sep 29, 2023

Conversation

Yurunsoft
Copy link
Member

Error:

Fatal error: Uncaught Error: Maximum call stack size of 8339456 bytes reached. Infinite recursion? 

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #5133 (4ba68a8) into master (b43bff8) will increase coverage by 0.02%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

❗ Current head 4ba68a8 differs from pull request most recent head b408c7f. Consider uploading reports for the commit b408c7f to get more accurate results

@@            Coverage Diff             @@
##           master    #5133      +/-   ##
==========================================
+ Coverage   72.97%   73.00%   +0.02%     
==========================================
  Files          69       69              
  Lines       14848    14853       +5     
==========================================
+ Hits        10836    10844       +8     
+ Misses       4012     4009       -3     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Yurunsoft Yurunsoft marked this pull request as draft September 14, 2023 02:44
@Yurunsoft Yurunsoft marked this pull request as ready for review September 14, 2023 06:22
@matyhtf matyhtf merged commit a11fd13 into swoole:master Sep 29, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants