Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4492 #4507

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Fix #4492 #4507

merged 4 commits into from
Nov 23, 2021

Conversation

matyhtf
Copy link
Member

@matyhtf matyhtf commented Nov 23, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #4507 (36c67b6) into master (bd8e5f8) will increase coverage by 3.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4507      +/-   ##
==========================================
+ Coverage   53.15%   56.82%   +3.67%     
==========================================
  Files          73       66       -7     
  Lines       14968    12988    -1980     
==========================================
- Hits         7956     7381     -575     
+ Misses       7012     5607    -1405     
Impacted Files Coverage Δ
src/protocol/base.cc 63.97% <0.00%> (-1.87%) ⬇️
thirdparty/hiredis/read.c
thirdparty/hiredis/alloc.h
thirdparty/hiredis/alloc.c
thirdparty/hiredis/hiredis.c
thirdparty/hiredis/sds.c
thirdparty/hiredis/net.c
thirdparty/hiredis/sds.h

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd8e5f8...36c67b6. Read the comment docs.

@matyhtf matyhtf merged commit d7032c6 into master Nov 23, 2021
@matyhtf matyhtf deleted the fix-4492 branch November 23, 2021 11:30
matyhtf added a commit that referenced this pull request Nov 24, 2021
* fix #4492

* Add tests

* fix

* fix 2
# Conflicts:
#	ext-src/swoole_http2_server.cc
#	ext-src/swoole_http_response.cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant