Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make context darwin arm64: removes workaround and uses the label #4127

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Apr 1, 2021

directly. LLVM support those since quite some years now.

directly. LLVM support those since quite some years now.
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #4127 (a8c69d6) into master (ab994a0) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4127      +/-   ##
==========================================
- Coverage   48.81%   48.77%   -0.05%     
==========================================
  Files          71       71              
  Lines       14280    14280              
==========================================
- Hits         6971     6965       -6     
- Misses       7309     7315       +6     
Impacted Files Coverage Δ
src/protocol/base.cc 63.15% <0.00%> (-1.98%) ⬇️
src/network/client.cc 46.56% <0.00%> (-0.45%) ⬇️
src/os/async_thread.cc 69.29% <0.00%> (-0.44%) ⬇️
src/server/port.cc 50.27% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab994a0...a8c69d6. Read the comment docs.

@devnexen
Copy link
Contributor Author

devnexen commented Apr 1, 2021

note I upstreamed this change just today.

@matyhtf matyhtf merged commit 1562c2c into swoole:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants