Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix native-curl crash on PHP8 #4045

Merged
merged 6 commits into from
Feb 7, 2021
Merged

fix native-curl crash on PHP8 #4045

merged 6 commits into from
Feb 7, 2021

Conversation

matyhtf
Copy link
Member

@matyhtf matyhtf commented Feb 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #4045 (d509d6b) into master (e678bba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4045   +/-   ##
=======================================
  Coverage   47.76%   47.77%           
=======================================
  Files          71       71           
  Lines       14277    14279    +2     
=======================================
+ Hits         6820     6822    +2     
  Misses       7457     7457           
Impacted Files Coverage Δ
src/core/base.cc 75.38% <100.00%> (ø)
src/core/timer.cc 83.05% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e678bba...d509d6b. Read the comment docs.

@matyhtf matyhtf merged commit 289e673 into master Feb 7, 2021
@matyhtf matyhtf deleted the fix-native-curl-php8 branch February 7, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant