Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support closing the connection in another process with base mode #3916

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

matyhtf
Copy link
Member

@matyhtf matyhtf commented Dec 7, 2020

No description provided.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #3916 (9557902) into master (f2238a7) will decrease coverage by 0.14%.
The diff coverage is 16.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3916      +/-   ##
==========================================
- Coverage   48.98%   48.83%   -0.15%     
==========================================
  Files          69       69              
  Lines       12849    12873      +24     
==========================================
- Hits         6294     6287       -7     
- Misses       6555     6586      +31     
Impacted Files Coverage Δ
src/network/socket.cc 59.69% <0.00%> (-0.54%) ⬇️
src/server/base.cc 54.38% <0.00%> (+0.47%) ⬆️
src/server/reactor_process.cc 41.89% <0.00%> (-0.51%) ⬇️
src/server/master.cc 51.55% <27.77%> (-1.67%) ⬇️
src/os/async_thread.cc 70.38% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2238a7...9557902. Read the comment docs.

@matyhtf matyhtf merged commit 98d4a78 into master Dec 7, 2020
@matyhtf matyhtf deleted the support-close-in-another-worker branch December 7, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant