Empty file upload fix #2779
Merged
Empty file upload fix #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sshymko
commented
Aug 26, 2019
•
sshymko
commented
- Distinguish blank file field from empty file contents
- Fix upload of file with empty contents of zero length
- Prevent empty temp file creation for blank file field
- Remove irrelevant MIME type of blank file field
- Resolve Cannot upload empty file or blank file field #2778 Cannot upload empty file or blank file field
|
Tests should cover both blank file field and legitimate upload of file with empty contents. |
sshymko
force-pushed
the
file_upload_blank_fix
branch
2 times, most recently
from
62d18c6
to
0274c19
Compare
sshymko
changed the title
sshymko
force-pushed
the
file_upload_blank_fix
branch
3 times, most recently
from
b13f515
to
5ca0dbe
Compare
- Distinguish blank file field from empty file contents - Fix inability to upload empty file of zero size - Prevent empty temp file creation for blank file field - Remove irrelevant MIME type of blank file field - Resolve swoole#2778 Cannot upload empty file or blank file field
- Cover upload of empty file of zero size with tests - Cover form submission of blank file field with tests - Resolve swoole#2778 Cannot upload empty file or blank file field
- Fix emulation of blank file field upload - Replace cURL file uploader with raw socket - Resolve swoole#2778 Cannot upload empty file or blank file field
sshymko
force-pushed
the
file_upload_blank_fix
branch
from
42d9e37
to
8fa9c98
Compare
|
All tests pass, the PR is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.