Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zpopmin & zpopmax for Redis 5 #2684

Merged
merged 11 commits into from
Jul 29, 2019
Merged

Add zpopmin & zpopmax for Redis 5 #2684

merged 11 commits into from
Jul 29, 2019

Conversation

ruesin
Copy link
Contributor

@ruesin ruesin commented Jul 12, 2019

适应Redis 5,为Swoole\Coroutine\Redis新增了几个方法:ZPOPMIN,ZPOPMAX,BZPOPMIN,BZPOPMAX

因为镜像中Redis的版本是4,所以测试用例没通过,但使用我自己的Redis 5 容器测试是正常的。

@matyhtf
Copy link
Member

matyhtf commented Jul 27, 2019

  1. if 与 ( 之间需要加空格,保持风格统一
  2. 命名使用 zPopMin 小驼峰风格
  3. 单元测试未检测 Redis 是否为 5.0 版本

@matyhtf matyhtf merged commit 7df2976 into swoole:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants