Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mysqli write_property error #26

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Fix mysqli write_property error #26

merged 2 commits into from
Apr 22, 2020

Conversation

twose
Copy link
Member

@twose twose commented Apr 21, 2020

No description provided.

@twose twose requested a review from deminy April 21, 2020 08:53
deminy
deminy reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@deminy deminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex is slow. Personally, I prefer to call isset() or array_key_exists() on an associative array instead of using regex.

src/core/Database/MysqliStatementProxy.php Outdated Show resolved Hide resolved
src/core/Database/MysqliProxy.php Outdated Show resolved Hide resolved
src/core/Database/MysqliProxy.php Outdated Show resolved Hide resolved
@deminy deminy merged commit 3960818 into master Apr 22, 2020
@twose twose deleted the mysqli branch April 22, 2020 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deminy deminy deminy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twose @deminy