Optimize Thread\Pool::withArguments()

swoole · Sep 30, 2024 · f7c16a7 · f7c16a7
1 parent 6f6113a
commit f7c16a7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/core/Thread/Pool.php b/src/core/Thread/Pool.php
@@ -45,7 +45,7 @@ public function __construct(string $runnableClass, int $threadNum)
         $this->threadNum     = $threadNum;
     }
 
-    public function withArguments(array $arguments): static
+    public function withArguments(...$arguments): static
     {
         $this->arguments = $arguments;
         return $this;
@@ -66,7 +66,7 @@ public function withClassDefinitionFile(string $classDefinitionFile): static
     /**
      * @throws \ReflectionException
      */
-    public function start(array $arguments = []): void
+    public function start(): void
     {
         if (empty($this->classDefinitionFile) and class_exists($this->runnableClass, false)) {
             $file = (new \ReflectionClass($this->runnableClass))->getFileName();

diff --git a/tests/unit/Thread/PoolTest.php b/tests/unit/Thread/PoolTest.php
@@ -27,7 +27,7 @@ public function testPool(): void
 
         (new Pool(TestThread::class, 4))
             ->withClassDefinitionFile(dirname(__DIR__, 2) . '/TestThread.php')
-            ->withArguments([uniqid(), $map])
+            ->withArguments(uniqid(), $map)
             ->start()
         ;