DO NOT MERGE! Only intended for showing changes since 2025/01/16 generated code! #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several problems with the generated code: * Realtime spec (https://platform.openai.com/docs/api-reference/realtime) allows some null fields to have special meaning; Moshi defaults to not sending null fields; add SerializeNull to allow some fields to be sent null. * Session `max_response_output_tokens` (https://platform.openai.com/docs/api-reference/realtime-sessions/create#realtime-sessions-create-max_response_output_tokens) can be either a number (1.4096) or `"inf"`; Make `RealtimeSessionMaxResponseOutputTokens` support both. * Server is sending several undocumented values; add `in_progress`, `audio` * Server is sending null `previous_item_id`; make `previous_item_id` nullable * Removing unnecessary imports instead of renaming any
The purpose of this is to support writing a `RealtimeClient` class in a separate module. I do not want that code to have to rewrite request/response serialization. Conversely, I would like for the code to reuse as much of this module as useful. That code will be serializing RealtimeClientEvent* requests a lot. I see no reason why ApiClient.request **has** to be protected. The problem is that ApiClient.request is inline reified, and it seems that all inline reified methods need to have all methods they call have the same visibility. :/ It is definitely not ideal that I am making so many protected things public, but the methods I am making public seem harmless enough to do coding a more drastic refactor.
paulpv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.