dotnet-core: Bumping versions, cleaning up test-project#77
Open
mnsc wants to merge 3 commits into
Open
Conversation
TargetFramework to .net 5.0 All dependencies to latest as of now.
Cleaned up the csproj by removing the project and recreating it with the default xunit test project template (VS2019 preview)
Member
Author
|
I'm interested in learning more about github actions so I can give it a shot! It's kinda weird setup though to expect one test to fail but maybe I can get some inspiration from the other workflows. |
Member
|
Hi @mnsc
the idea behind it is to make it super easy for people just to start (even if they don't know the particular language or/and testing framework), since running the tests will point you to the next step. |
Remove workflows (to be reverted)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet-core-version wasn't working, bumped all versions to .net 5 (tested on .net5 rc2) and now it works.
While doing this I cleaned up the csproj by removing the project and recreating it with the default xunit test project template (VS2019 preview).
What got removed in the cleaning:
"Given that there's no point in packing test projects..."
dotnet/templating#376
"Note that DotNetCliToolReference is now deprecated in favor of .NET Core Local Tools."
https://docs.microsoft.com/en-us/dotnet/core/tools/csproj#dotnetclitoolreference
Magic guid that says "test project"
microsoft/vstest#472