Use new npdm-json format #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yellows8
reviewed
Sep 28, 2018
| }, | ||
| "service_access" : { | ||
| "*" : false, | ||
| "*" : true |
Contributor
There was a problem hiding this comment.
nx-hbloader needs both...
Contributor
Author
There was a problem hiding this comment.
Ugh. I totally missed that. This is another case of duplicated keys...
Contributor
Author
There was a problem hiding this comment.
Alright, we're going to split this into "service_access": ["*"] and "service_host": ["*"]
Contributor
Author
|
Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current NPDM format is going to change in the near future. In order to make it easier for the homebrew ecosystem to move to the new format, PRs have been issued automatically to upgrade your JSON to the new format. See switchbrew/switch-tools#20 for more information.
What you need to do
Right now, nothing. The PR to npdmtool is written in such a way that, when it's merged, both the old and new JSON formats will be accepted. Once it is merged and a new version of switch-tools has been published on the devkitPro repositories, you should merge this PR. I will leave a comment here when this is the case.