Add 'new_from_bytes' function and update dependencies #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xripleys
commented
Nov 30, 2022
| fn discriminator() -> [u8; 8] { | ||
| [50, 35, 51, 115, 169, 219, 158, 52] | ||
| } | ||
| const DISCRIMINATOR: [u8; 8] = [50, 35, 51, 115, 169, 219, 158, 52]; |
There was a problem hiding this comment.
anchor made a breaking change here.
0xripleys
commented
Nov 30, 2022
| solana-program = "~1.10.29" | ||
| anchor-lang = { git = "https://github.com/coral-xyz/anchor.git" } | ||
| anchor-spl = { git = "https://github.com/coral-xyz/anchor.git" } | ||
| rust_decimal = "1.26.0" |
There was a problem hiding this comment.
this rust decimal change isn't necessary
mgild
reviewed
Dec 1, 2022
| solana-program = "~1.10.29" | ||
| anchor-lang = { git = "https://github.com/coral-xyz/anchor.git" } | ||
| anchor-spl = { git = "https://github.com/coral-xyz/anchor.git" } | ||
| rust_decimal = "1.26.0" |
| /// | ||
| /// let data_feed = AggregatorAccountData::new(feed_account_info.try_borrow_data()?)?; | ||
| /// ``` | ||
| pub fn new_from_bytes(data: &[u8]) -> anchor_lang::Result<&AggregatorAccountData> { |
mgild
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AggregatorAccountData::new(account_info)that currently seem unfixable. I can get you an error snippet if you need one. The easy solution is to make a similar function that takes in a slice of bytes (instead of an account info), which avoids the lifetime stuff entirely.(1) should probably be merged, (2) probably not