Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple processing logic from uploading itself #568

Merged
merged 22 commits into from
Jul 18, 2024
Merged

Conversation

swissspidy
Copy link
Owner

@swissspidy swissspidy commented Jul 15, 2024

@mexp/upload-media won't have any upload logic, needs to be passed via settings

@mexp/media-utils only cares about uploading, like today. Doesn't have any state.

Also adds some initial file validation before the item is added to the queue.

See #561

@swissspidy swissspidy added the enhancement New feature or request label Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

Size Change: +181 B (+0.01%)

Total Size: 3.02 MB

Filename Size Change
build/media-experiments.js 68.8 kB +167 B (+0.24%)
ℹ️ View Unchanged
Filename Size Change
build/100.js 88.3 kB 0 B
build/699.js 2.35 MB 0 B
build/blurhash.worker.js 3.23 kB 0 B
build/canvas.worker.js 2.79 kB 0 B
build/chunk-ffmpeg.js 5.91 kB 0 B
build/chunk-selfie-segmentation.js 16.3 kB 0 B
build/dominant-color.worker.js 4.45 kB 0 B
build/ffmpeg.js 1.1 kB 0 B
build/heif.worker.js 422 kB 0 B
build/media-experiments-blocks-rtl.css 297 B 0 B
build/media-experiments-blocks.css 296 B 0 B
build/media-experiments-rtl.css 885 B 0 B
build/media-experiments.css 885 B 0 B
build/pdf.js 578 B 0 B
build/subtitles.js 848 B 0 B
build/view-upload-request-view-rtl.css 716 B 0 B
build/view-upload-request-view.css 717 B 0 B
build/view-upload-request.js 17.2 kB +14 B (+0.08%)
build/vips.worker.js 42.6 kB 0 B

compressed-size-action

@swissspidy swissspidy changed the title Decouple media-upload from WordPress Decouple processing logic from uploading itself Jul 16, 2024
@swissspidy swissspidy marked this pull request as ready for review July 16, 2024 21:35
@swissspidy swissspidy merged commit 958ab87 into main Jul 18, 2024
21 checks passed
@swissspidy swissspidy deleted the fix/561-decoupling branch July 18, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant