Ensure optimized images have correct metadata

[swissspidy]

When optimizing an existing image and converting it to AVIF, some metadata might be missing if the server doesn't natively support the format. _wp_attachment_metadata will only have filesize but nothing else.

width, height, file should be trivial to add. Either copy from original or generate client-side.

This is needed so that the missing_image_sizes logic for client-side thumbnail generation works as expected for AVIF. Right now missing_image_sizes returns an empty array.

[swissspidy]

Copying the data server-side works, but there are PHP warnings because width and height are missing initially when populating missing_image_sizes response field,

So providing client-side might be better.

Alternatively, on rest_after_insert_attachment hook into wp_generate_attachment_metadata to add the missing metadata. That would get rid of the PHP warnings and overall feels a bit cleaner.

[swissspidy]

When optimizing an existing image and converting it to AVIF, [...]

Probably also an issue when uploading an image directly as AVIF? in that case this must be done client-side either way.

Vips or canvas could be used to get image dimensions. After that, send to server via additionalData

[swissspidy]

I think 068ad7b resolved the last remaining issues here. Closing for now.