Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIS - transcationId replaced with entryId #107

Conversation

svenbiellmann
Copy link
Contributor

No description provided.

@svenbiellmann svenbiellmann requested a review from a team as a code owner July 12, 2024 08:06
@svenbiellmann svenbiellmann changed the base branch from main to release-v5 September 10, 2024 07:26
Copy link
Contributor

@dkoeni dkoeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it common understanding that entryId is linked to transactions? If not, we should consider renaming tranactions aswell..

@svenbiellmann
Copy link
Contributor Author

The question that arises is whether the endpoint should return the details about a transaction entry or the details about a single transaction item. The opinion in the working group was clear that the transaction entry should be returned. Returning the single transaction item does just not make sense.

image

@dkoeni dkoeni requested review from dkoeni and a team September 10, 2024 12:02
Copy link
Contributor

@dkoeni dkoeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@svenbiellmann svenbiellmann merged commit f73095c into release-v5 Sep 10, 2024
7 checks passed
@svenbiellmann svenbiellmann deleted the 99-ais-schema-definition-error-in-get-accountsaccountidtransactionstransactionid branch September 10, 2024 12:23
dkoeni pushed a commit that referenced this pull request Sep 13, 2024
transactionId replaced with entryId as input parameter in GET /transactions/accounts/{accountId}/transactions/{transactionId} endpoint in AIS
dkoeni pushed a commit that referenced this pull request Nov 6, 2024
transactionId replaced with entryId as input parameter in GET /transactions/accounts/{accountId}/transactions/{transactionId} endpoint in AIS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIS - schema definition error in GET /accounts/{accountId}/transactions/{transactionId}?
2 participants