Skip to content

Fixes issue where MariaDBs with VIEWs couldn't be backupped on iAPC #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes issue where MariaDBs with VIEWs couldn't be backupped on iAPC #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c89010
Using mysqlpump with the --skip-definer flag so dumps of views can be…
Oct 28, 2019
5472ba0
Alternative fix to mysqlpump because mysqlpump requires at lest mysql…
Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions service/mysql/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,22 +51,27 @@ func Backup(ctx context.Context, s3 *s3.Client, service util.Service, binding *c

// prepare mysqldump command
var command []string
command = append(command, "mysqldump")
command = append(command, "--single-transaction")
command = append(command, "--quick")
command = append(command, "--skip-add-locks")
command = append(command, "-h")
command = append(command, host)
command = append(command, "-P")
command = append(command, port)
command = append(command, "-u")
command = append(command, username)
command = append(command, "sh")
command = append(command, "-c")
var command_string_array []string
command_string_array = append(command_string_array, "mysqldump")
command_string_array = append(command_string_array, "--single-transaction")
command_string_array = append(command_string_array, "--quick")
command_string_array = append(command_string_array, "--skip-add-locks")
command_string_array = append(command_string_array, "-h")
command_string_array = append(command_string_array, host)
command_string_array = append(command_string_array, "-P")
command_string_array = append(command_string_array, port)
command_string_array = append(command_string_array, "-u")
command_string_array = append(command_string_array, username)
if len(database) > 0 {
command = append(command, "--databases")
command = append(command, database)
command_string_array = append(command_string_array, "--databases")
command_string_array = append(command_string_array, database)
} else {
command = append(command, "--all-databases")
command_string_array = append(command_string_array, "--all-databases")
}
command_string_array = append(command_string_array, "| sed -e 's/DEFINER[ ]*=[ ]*[^*]*\\*/\\*/'")
command = append(command, strings.Join(command_string_array, " "))

log.Debugf("executing mysql backup command: %v", strings.Join(command, " "))
cmd := exec.CommandContext(ctx, command[0], command[1:]...)
Expand Down