Update go-dockerclient #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should probably test against the latest 1.x version of Go, but we can also continue testing against 1.6 if we want. In either case we don't need `make get-deps`, since dependencies are (and have been) vendored. Future editors of this file: this is precariously close to a loaded footgun. https://twitter.com/davecheney/status/964669282855485440
|
Thanks a lot, @willglynn I am busy this week, will try it this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
github.com/fsouza/go-dockerclientto currentmaster, which would fix #27 if that issue works the way I think it does. We should probably check before merging.This PR also switches from
godeptodep. That is partly becausedepis now the official dependency management experiment, but mostly it's because I couldn't getgodepto cooperate.dep initcopied over all the references fromGodeps.json, so that part of the changeset shouldn't have any side effects.