Rebase 2020/01/25

[kateinoigakukun]

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

[MaxDesiatov]

Not sure why CI wasn't triggered here 🤔

[kateinoigakukun]

Hmm, I can't figure out the reason too 🤔
But passed on my forked repo https://github.com/kateinoigakukun/swiftwasm/runs/408402915

[kateinoigakukun]

@MaxDesiatov BTW I'm thinking to change the strategy of tracking upstream changes because rebasing branch is very hard and likely causes big conflict.
I know merge commit makes the commit history redundant, but rebasing operation takes more cost. So I'm trying to use pull Github App which creates merge pull request when upstream branch updated like this.

This strategy makes conflict as small as possible and more safely because we don't have to use force-push to swiftwasm branch.

What do you think about this?

[MaxDesiatov]

@kateinoigakukun this makes sense, fine by me 🙂

[MaxDesiatov]

Why GitHub Actions does not run for PRs made from this branch is still a mystery to me 🤨

[karwa]

One thing that might be worthwhile is to squash many of the earlier changes. There used to be lots of hacks that have since been removed, etc. In fact, the total diff required to get this port working isn't very big or hard to maintain (mostly new files or adding a few lines for wasi here and there).

[MaxDesiatov]

I agree, I'm also trying to upstream as much of it as possible in small PRs in the next few weeks, which should make the total diff even smaller after those are merged.

[kateinoigakukun]

Now, I'm tracking apple/master branch here https://github.com/kateinoigakukun/swiftwasm/tree/swiftwasm

I'll clone this pr and could you force-push this? @MaxDesiatov

I hope this is final force-push.

[MaxDesiatov]

cool, that's done now ✅

[kateinoigakukun]

@MaxDesiatov Thanks!