Skip to content

Fix cross-compilation issues in 5.3 after arm64 upstream merge #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Jul 7, 2020
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
87612b4
[Apple Silicon] Add arm64 macOS support to benchmark suite
shahmishal Jul 2, 2020
8d74d35
[Apple Silicon][Test] Enable testing for arm64 macOS
shahmishal Jul 2, 2020
d795169
[Apple Silicon] Mark several tests that require the Swift interpreter…
shahmishal Jul 2, 2020
d5b48bc
[Apple Silicon] Generalize tests for other macOS architectures
shahmishal Jul 2, 2020
e24f7df
[Apple Silicon] Mark macOS tests that require x86_64
shahmishal Jul 2, 2020
6c183c8
[Apple Silicon] [Build] Generalize macOS architecture check
shahmishal Jul 2, 2020
76c5fac
[Apple Silicon] [ObjectiveC Overlay] ObjCBool is C _Bool on arm64 macOS.
shahmishal Jul 2, 2020
16110be
[Apple Silicon] Baseline arm64 macOS at Swift 5.3 / macOS 10.16
shahmishal Jul 2, 2020
7c94216
[Apple Silicon] [Test] Fix various IRGen tests for arm64 macOS
shahmishal Jul 3, 2020
781aa53
[Apple Silicon] [Test] Generalize api-digester tests for Apple Silico…
shahmishal Jul 3, 2020
885ef36
[Apple Silicon] Support building for macOS arm64/arm64e
shahmishal Jul 3, 2020
3b74951
[Apple Silicon] [build-script] Support stdlib macOS arm64/arm64e
shahmishal Jul 3, 2020
d84da25
[Apple Silicon] Use SWIFT_CROSS_COMPILING to use build-time tools (tb…
shahmishal Jul 3, 2020
676b9af
[Apple Silicon] Don't set native llvm tools path when cross compiling…
shahmishal Jul 3, 2020
b850bc6
[Apple Silicon] [build-script] Build compiler-rt even when cross-comp…
shahmishal Jul 3, 2020
824a3e6
[Apple Silicon] [build-script] Fix cross-compile check.
shahmishal Jul 3, 2020
39ee89f
[Apple Silicon] Build system configuration to support arm64 macOS
shahmishal Jul 3, 2020
05028a2
[Apple Silicon] [build-script] Fix lipo step invocation with --no-leg…
shahmishal Jul 3, 2020
2ef95d3
[Apple Silicon] Fix cross-compilation in Xcode trains where we're not…
shahmishal Jul 3, 2020
69ead9d
[Apple Silicon] [Platform] Default arm64 macOS and arm64 simulators t…
shahmishal Jul 3, 2020
7ca2bac
[Apple Silicon] [IRGen] Fix test for arm64 macOS
shahmishal Jul 3, 2020
0360f68
[Apple Silicon] [macCatalyst] Baseline arm64(e) macCatalyst at Swift …
shahmishal Jul 3, 2020
5566ace
[Apple Silicon] Adjust linking deployment target from 11.0 down to 10…
shahmishal Jul 3, 2020
e5d11ff
[Apple Silicon] [In-process memory reader] Adjust low-bits computatio…
shahmishal Jul 3, 2020
0b73826
[Apple Silicon] [Build] Filter out any architectures that are unsuppo…
shahmishal Jul 3, 2020
dedd426
[Apple Silicon] [Test] Fix a few tests for SDK differences
shahmishal Jul 3, 2020
8364ec9
[Apple Silicon] [Test] Remove explicitly-specified target.
shahmishal Jul 3, 2020
795c363
[Apple Silicon] Simulator support for arm64
shahmishal Jul 3, 2020
00a9c11
[Apple Silicon] [Platform] Baseline arm64 simulators at iOS/tvOS 14.0…
shahmishal Jul 3, 2020
54d8f93
[Apple Silicon] Use a correct isa mask on Apple Silicon without signe…
shahmishal Jul 3, 2020
0c5dc54
[Apple Silicon] Fix the availability for Swift 5.3 version
shahmishal Jul 3, 2020
d764db0
[Apple Silicon] Add support for triple and availability canonicalization
shahmishal Jul 3, 2020
f3a6146
[Apple Silicon] Update tests for no macOS target triple canonicalization
shahmishal Jul 3, 2020
962ce48
[Apple Silicon] Remove tvOS/watchOS simulator from Driver/linker test
shahmishal Jul 3, 2020
3b9218a
Merge pull request #32706 from apple/apple-silicon-5.3
shahmishal Jul 5, 2020
bdf987a
Merge branch 'release/5.3' of github.com:swiftwasm/swift into maxd/5.…
MaxDesiatov Jul 6, 2020
7016cb5
[WASM] Resolve build failure by fixing cross compile issue on build-s…
kateinoigakukun Jul 6, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Apple Silicon] [build-script] Fix lipo step invocation with --no-leg…
…acy-impl.

LIPO_SRC_DIRS wasn't set for '--only-execute merged-hosts-lipo',
because the logic was skipped for actions other than install.
  • Loading branch information
shahmishal committed Jul 3, 2020
commit 05028a2d941bece95e77c47d84a22ea4b25a44ed
22 changes: 11 additions & 11 deletions utils/build-script-impl
Original file line number Diff line number Diff line change
Expand Up @@ -3023,21 +3023,21 @@ done

# Lipo those products which require it, optionally build and test an installable package.
mergedHost="merged-hosts"
if [[ ${#LIPO_SRC_DIRS[@]} -gt 0 ]] && [[ $(should_execute_action "${mergedHost}-lipo") ]]; then
if [[ ${#LIPO_SRC_DIRS[@]} -gt 0 ]]; then
# This is from multiple hosts; Which host should we say it is?
# Let's call it 'merged-hosts' so that we can identify it.

echo "--- Merging and running lipo ---"
if [[ $(should_execute_action "${mergedHost}-lipo") ]]; then
# Allow passing lipo with --host-lipo
if [[ -z "${HOST_LIPO}" ]] ; then
LIPO_PATH=$(xcrun_find_tool lipo)
else
LIPO_PATH="${HOST_LIPO}"
fi
call "${SWIFT_SOURCE_DIR}"/utils/recursive-lipo --lipo=${LIPO_PATH} --copy-subdirs="$(get_host_install_prefix ${host})lib/swift $(get_host_install_prefix ${host})lib/swift_static" --destination="$(get_host_install_destdir ${mergedHost})" ${LIPO_SRC_DIRS[@]}

# Allow passing lipo with --host-lipo
if [[ -z "${HOST_LIPO}" ]] ; then
LIPO_PATH=$(xcrun_find_tool lipo)
else
LIPO_PATH="${HOST_LIPO}"
# Build and test the lipo-ed package.
build_and_test_installable_package ${mergedHost}
fi
call "${SWIFT_SOURCE_DIR}"/utils/recursive-lipo --lipo=${LIPO_PATH} --copy-subdirs="$(get_host_install_prefix ${host})lib/swift $(get_host_install_prefix ${host})lib/swift_static" --destination="$(get_host_install_destdir ${mergedHost})" ${LIPO_SRC_DIRS[@]}

# Build and test the lipo-ed package.
build_and_test_installable_package ${mergedHost}
fi
# END