Generalize findSwiftExecutable into findExecutable
#436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omochi
commented
May 17, 2024
| return try AbsolutePath(validating: path) | ||
| } | ||
|
|
||
| func findSwiftExecutable() throws -> AbsolutePath { |
There was a problem hiding this comment.
String ではなく AbsolutePath を返すように変更しています。
その方がさまざまな CartonHelper の他のコードと一緒に使いやすいからです。
|
CI failing |
|
2重否定間違えるやつ やらかした guard path.isEmpty else {
throw CommandTestError("Output from \(whichBin) is empty")
} |
|
@kateinoigakukun CIが治ったので改めて確認お願いします |
kateinoigakukun
changed the title
findSwiftExecutable into findExecutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題
テストでは
findSwiftExecutableという関数が便利に使われていますが、swiftコマンド以外のコマンドを探すことができません。#434 のように他のコマンドも探せると便利です。
提案
findExecutableを実装します。見つからなかった場合には以下のようにエラーメッセージを出します。
背景
#434 で curl を使おうとしたらどうやら見つからなかったのですが、
findExecutableの実装上エラーログが貧弱で対処しづらそうでした。#434 の変更をなるべく小さくするため、
この改善だけ単品で切り出したパッチを作りました。