Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit non-zero status when test fail on browser #370

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Exit non-zero status when test fail on browser #370

merged 2 commits into from
Jul 18, 2022

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jul 18, 2022 •
edited
Loading

Close #367

This PR changes to:

  1. Exit non-zero status when test fail when --environment defaultBrowser
  2. Exit non-zero status when JS exception is thrown (e.g. JS throw, hitting unreachable, or memory OOB error)

@kateinoigakukun kateinoigakukun added the bug Something isn't working label Jul 18, 2022
@kateinoigakukun kateinoigakukun requested review from MaxDesiatov and a team and removed request for MaxDesiatov July 18, 2022 16:25
MaxDesiatov
MaxDesiatov approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, great catch! 👏

@kateinoigakukun kateinoigakukun merged commit 2fa2568 into main Jul 18, 2022
@kateinoigakukun kateinoigakukun deleted the katei/fix-exception-while-test branch July 18, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

carton test should fail if crashing during _initialize
2 participants
@kateinoigakukun @MaxDesiatov