Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headless test runner #362

Merged
merged 17 commits into from
Jun 10, 2022
Merged

Headless test runner #362

merged 17 commits into from
Jun 10, 2022

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jun 9, 2022

Motivation

carton test --environment defaultBrowser only works on macOS or X Window systems, so tests using browser APIs cannot be run on CI easily. Add a headless test runner based on WebDriver.

Changed

@kateinoigakukun kateinoigakukun added the enhancement New feature or request label Jun 9, 2022
@kateinoigakukun kateinoigakukun marked this pull request as ready for review June 9, 2022 16:48
@kateinoigakukun kateinoigakukun requested a review from a team June 9, 2022 16:48
@MaxDesiatov
Copy link
Collaborator

Is this new option compatible with other --environment values? If not, maybe it should be implemented as --environment webdriver?

@kateinoigakukun
Copy link
Member Author

@MaxDesiatov I made it as a new flag instead of a --environment variant because I thought --environment is designed to accept specific browser names in the future like --environment firefox and then --headless should be able to be used with defaultBrowser and other browser values.

@MaxDesiatov
Copy link
Collaborator

That makes sense, thanks!

README.md Outdated Show resolved Hide resolved
Co-authored-by: Max Desiatov <max@desiatov.com>
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! 👏

@kateinoigakukun kateinoigakukun enabled auto-merge (squash) June 10, 2022 16:12
@kateinoigakukun kateinoigakukun merged commit 646f1ae into main Jun 10, 2022
@kateinoigakukun kateinoigakukun deleted the katei/headless-test-runner branch June 10, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants