Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use from instead of upToNextMinor for OpenCombine #34

Merged
merged 4 commits into from
Jul 8, 2020
Merged

Use from instead of upToNextMinor for OpenCombine #34

merged 4 commits into from
Jul 8, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Jul 8, 2020 •
edited
Loading

This comes after I was reminded that we're using an old version in #33.

@MaxDesiatov MaxDesiatov added the dependencies Updates to the project dependencies label Jul 8, 2020
@ie-ahm-robox
Copy link
Contributor

Fails
🚫

Package.swift#L17 - Line should be 100 characters or less: currently 104 characters (line_length)
🚫

Package.swift#L18 - Line should be 100 characters or less: currently 118 characters (line_length)

Generated by 🚫 Danger Swift against 9a4e258

ie-ahm-robox
ie-ahm-robox reviewed Jul 8, 2020
View reviewed changes
Package.swift Outdated
@@ -10,7 +10,7 @@ let package = Package(
.package(url: "https://github.com/swift-server/async-http-client.git", from: "1.1.1"),
.package(url: "https://github.com/apple/swift-argument-parser", .upToNextMinor(from: "0.2.0")),
.package(url: "https://github.com/apple/swift-tools-support-core.git", .upToNextMinor(from: "0.1.3")),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 Line should be 100 characters or less: currently 106 characters (line_length)

ie-ahm-robox
ie-ahm-robox reviewed Jul 8, 2020
View reviewed changes
Package.swift Outdated
.package(url: "https://github.com/apple/swift-tools-support-core.git", .upToNextMinor(from: "0.1.3")),
.package(url: "https://github.com/OpenCombine/OpenCombine.git", .upToNextMinor(from: "0.10.0")),
.package(
url: "https://github.com/apple/swift-argument-parser",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 Lines should not have trailing whitespace. (trailing_whitespace)

@ie-ahm-robox
Copy link
Contributor

Fails
🚫

Package.swift#L16 - Lines should not have trailing whitespace. (trailing_whitespace)
🚫

Package.swift#L23 - Line should be 100 characters or less: currently 104 characters (line_length)
🚫

Package.swift#L24 - Line should be 100 characters or less: currently 118 characters (line_length)

Generated by 🚫 Danger Swift against ddc8d3c

@ie-ahm-robox
Copy link
Contributor

Fails
🚫

Package.swift#L24 - Line should be 100 characters or less: currently 118 characters (line_length)

Generated by 🚫 Danger Swift against 327015f

@swiftwasm swiftwasm deleted a comment from ie-ahm-robox Jul 8, 2020
@broadwaylamb
Copy link
Contributor

BTW, does Package.resolved need to be updated as well?

@MaxDesiatov
Copy link
Collaborator Author

It's already updated by your PR, and it doesn't encode the version constraints as far as I'm aware. The bot runs swift package update every night and will submit a PR with changes to Package.resolved if any are needed.

@MaxDesiatov MaxDesiatov merged commit bfe8650 into main Jul 8, 2020
@MaxDesiatov MaxDesiatov deleted the from-opencombine branch July 8, 2020 12:53
@broadwaylamb
Copy link
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ie-ahm-robox ie-ahm-robox ie-ahm-robox left review comments

Assignees
No one assigned
Labels
dependencies Updates to the project dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxDesiatov @ie-ahm-robox @broadwaylamb