Skip to content

Several fixes for 5.6 toolchain #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 9, 2022
Merged

Several fixes for 5.6 toolchain #310

merged 12 commits into from
Apr 9, 2022

Conversation

@kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Apr 6, 2022 •
edited
Loading

  • Reactor model support
  • Update sanitizer support object

This is required to resolve TokamakUI/Tokamak#475

@kateinoigakukun kateinoigakukun added the bug Something isn't working label Apr 6, 2022
@kateinoigakukun kateinoigakukun mentioned this pull request Apr 6, 2022
Merged
MaxDesiatov
MaxDesiatov previously approved these changes Apr 6, 2022
View reviewed changes
@MaxDesiatov
Copy link
Member

MaxDesiatov commented Apr 6, 2022

Thank you so much for investigating it. This is great, I really appreciate your hard work on these issues! 🙏

@MaxDesiatov
Copy link
Member

MaxDesiatov commented Apr 6, 2022

Do we still need so_sanitizer.wasm file for this to work? With this PR as is I get ~/.carton/static/so_sanitizer.wasm: No such file or directory error, but I'm not sure if this file is no longer needed and we're no longer supposed to link with it, or the file was just lost in my static.zip archival process.

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Apr 7, 2022

Hmm, weird. I didn't change anything except for the content of so_sanitizer.wasm. The support object file is still necessary.

@MaxDesiatov MaxDesiatov mentioned this pull request Apr 8, 2022
Merged
@MaxDesiatov
Copy link
Member

MaxDesiatov commented Apr 8, 2022

I had to point tests utilizing Tokamak to the branch of TokamakUI/Tokamak#475. Waiting for that to be approved, then will tag new Tokamak and merge this one.

MaxDesiatov
MaxDesiatov previously approved these changes Apr 9, 2022
View reviewed changes
@MaxDesiatov MaxDesiatov added the dependencies Updates to the project dependencies label Apr 9, 2022
@MaxDesiatov MaxDesiatov enabled auto-merge (squash) April 9, 2022 12:34
@MaxDesiatov MaxDesiatov merged commit 9c4021d into main Apr 9, 2022
@MaxDesiatov MaxDesiatov deleted the katei/fix-for-5.6 branch April 9, 2022 13:37
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Apr 11, 2022 •
edited
Loading

Ah, 204587d was a wrong fix and it silence the breakage of carton test 😢

#313

@kateinoigakukun kateinoigakukun mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees

No one assigned

Labels

bug Something isn't working dependencies Updates to the project dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kateinoigakukun @MaxDesiatov