Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't strip custom sections when --debug-info #304

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Don't strip custom sections when --debug-info #304

merged 1 commit into from
Mar 31, 2022

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Mar 31, 2022 •
edited
Loading

Since #301, carton started passing --debuginfo to wasm-opt, but it still strips all custom sections before it.

@kateinoigakukun kateinoigakukun added the bug Something isn't working label Mar 31, 2022
MaxDesiatov
MaxDesiatov approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@MaxDesiatov MaxDesiatov merged commit 32474ae into main Mar 31, 2022
@MaxDesiatov MaxDesiatov deleted the katei/dont-strip-name-section branch March 31, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @MaxDesiatov