Fix browser testing for Safari, update tasks.json #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecb4
reviewed
Jan 1, 2021
|
Are you referring to the commented code removed in 9f669f2? Sorry about that, just some experiments I've done locally slipped in. They are removedin the latest commit here. |
yonihemi
approved these changes
Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #200 for macOS. We still probably need to prepare an image (maybe separate image to keep the primary image slim enough) with pre-installed browsers for testing on Linux to work.
This should fix GitHub Actions not running any of the browser tests on macOS. Thanks to @thecb4 for finding the cause of the issue!
I've also updated VSCode's
tasks.jsonwith new fixtures paths and simplified subdirectory nesting forTestApp.