Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test command test with no arguments #198

Merged
merged 6 commits into from
Dec 30, 2020
Merged

Add test command test with no arguments #198

merged 6 commits into from
Dec 30, 2020

Conversation

thecb4
Copy link
Contributor

@thecb4 thecb4 commented Dec 29, 2020

This is in support of #99

Added

  • Test Command Test with no arguments

Changed

  • Moved TestApp, entrypoint, package.json, and package-lock.json folder to Test/Fixtures/carton-test
  • Script for GitHub Actions now builds (including tests) then runs the tests separately.
  • Dockerfile now builds (including tests) then runs the tests separately.

Removed

  • Script for GitHub Actions no longer references TestApp
  • Dockerfile no longer references TestApp

@thecb4 thecb4 added continuous integration Continuous integration changes refactor No user-visible functionality change labels Dec 29, 2020
@MaxDesiatov MaxDesiatov changed the title Added test command test with no arguments Add test command test with no arguments Dec 29, 2020
@thecb4 thecb4 requested review from MaxDesiatov and a team and removed request for MaxDesiatov December 30, 2020 10:07
MaxDesiatov
MaxDesiatov requested changes Dec 30, 2020
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the entrypoint directory and package.json/package-lock.json back to the root from the Fixtures dir? It's used for entrypoints for all commands, not just in the fixture.

@thecb4
Copy link
Contributor Author

thecb4 commented Dec 30, 2020

Sure - moved them back.

@MaxDesiatov
Copy link
Collaborator

And the entrypoint directory too please 🙂

MaxDesiatov
MaxDesiatov approved these changes Dec 30, 2020
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👏

@thecb4 thecb4 merged commit fc0487d into swiftwasm:main Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
continuous integration Continuous integration changes refactor No user-visible functionality change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecb4 @MaxDesiatov