Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid repeated loadingMessage in ProcessRunner #138

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Avoid repeated loadingMessage in ProcessRunner #138

merged 1 commit into from
Oct 22, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

Without this patch ProcessRunner output pollutes non-interactive terminals such as GitHub Actions logs, where loadingMessage value is printed multiple times in a row for every compiled file.

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Oct 21, 2020
@MaxDesiatov MaxDesiatov requested a review from a team October 21, 2020 18:10
@MaxDesiatov MaxDesiatov merged commit c3d108d into main Oct 22, 2020
@MaxDesiatov MaxDesiatov deleted the repeated-message branch October 22, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carson-katri carson-katri carson-katri approved these changes

@yonihemi yonihemi yonihemi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxDesiatov @yonihemi @carson-katri