Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically open a browser window when Dev Server starts #117

Merged
merged 4 commits into from
Oct 2, 2020

Conversation

yonihemi
Copy link
Member

@yonihemi yonihemi commented Oct 2, 2020

Resolves #92.
While there a lot more options possible to cram here I think this is a decent start. Perhaps an opportunity for a cross-platform Swift launcher µ framework?

@MaxDesiatov MaxDesiatov added the enhancement New feature or request label Oct 2, 2020
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This is wonderful, thank you so much 🙏

@MaxDesiatov MaxDesiatov requested a review from a team October 2, 2020 15:53
@MaxDesiatov
Copy link
Collaborator

MaxDesiatov commented Oct 2, 2020

@yonihemi Thanks again for your contributions, I've sent you an invitation to the @swiftwasm/carton-team team if you're interested in joining, feel free to merge it yourself after you accept it, or wait for a few more approvals if you want to get something close to a team consensus (not required, but desirable, unless we rush some important pre-release PRs 🙂)

@yonihemi yonihemi merged commit 0731ccb into swiftwasm:main Oct 2, 2020
@yonihemi yonihemi deleted the dev_open_browser branch October 2, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

carton dev should open a browser window when server starts
4 participants