Skip to content

WasmParser: Specialize more hot paths #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Oct 23, 2024

With this change, we can achieve 17% speedup on stringify macro
benchmark. The performance number is same as the case with CMO but with
smaller binary size.

baseline CMO this change
speed (ms) 198.1 172.8 169.9
size (kb) 1 1739 1923 1797

Footnotes

  1. swift-6.0.1-RELEASE, macOS 14.4.1 arm64

With this change, we can achieve 17% speedup on stringify macro
benchmark. The performance number is same as the case with CMO but with
smaller binary size.

|            | baseline | CMO   | this change |
|------------|----------|-------|-------------|
| speed (ms) | 198.1    | 172.8 | 169.9       |
| size  (kb) | 1739     | 1923  | 1797        |
@kateinoigakukun kateinoigakukun merged commit 0a8161e into main Oct 23, 2024
12 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/inline-parseint branch October 23, 2024 11:40
@kkebo
Copy link
Contributor

kkebo commented Oct 23, 2024

Out of curiosity, what would happen if you combined this change with CMO?

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Oct 23, 2024

No speed up but it just adds code size

baseline CMO this change this change + CMO
speed (ms) 198.1 172.8 169.9 170.3
size (kb) 1739 1923 1797 1897

@kkebo
Copy link
Contributor

kkebo commented Oct 23, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants