Skip to content

WasmParser: Reduce code size #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/WAT/Encoder.swift
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ struct ExpressionEncoder: InstructionEncoder {
mutating func encodeImmediates(globalIndex: UInt32) throws { encodeUnsigned(globalIndex) }
mutating func encodeImmediates(localIndex: UInt32) throws { encodeUnsigned(localIndex) }
mutating func encodeImmediates(memarg: WasmParser.MemArg) throws {
encodeUnsigned(UInt(memarg.align.trailingZeroBitCount))
encodeUnsigned(UInt(memarg.align))
encodeUnsigned(memarg.offset)
}
mutating func encodeImmediates(memory: UInt32) throws { encodeUnsigned(memory) }
Expand Down
419 changes: 197 additions & 222 deletions Sources/WAT/InstructionEncoder.swift

Large diffs are not rendered by default.

360 changes: 180 additions & 180 deletions Sources/WAT/ParseInstruction.swift

Large diffs are not rendered by default.

76 changes: 7 additions & 69 deletions Sources/WAT/Parser/ExpressionParser.swift
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,12 @@ struct ExpressionParser<Visitor: InstructionVisitor> {
if let maybeAlign = try parser.peekKeyword(), maybeAlign.starts(with: alignPrefix) {
try parser.consume()
var subParser = Parser(String(maybeAlign.dropFirst(alignPrefix.count)))
align = try subParser.expectUnsignedInt(UInt32.self)
let rawAlign = try subParser.expectUnsignedInt(UInt32.self)

if align == 0 || align & (align - 1) != 0 {
if rawAlign == 0 || rawAlign & (rawAlign - 1) != 0 {
throw WatParserError("alignment must be a power of 2", location: subParser.lexer.location())
}
align = UInt32(rawAlign.trailingZeroBitCount)
}
return MemArg(offset: offset, align: align)
}
Expand Down Expand Up @@ -467,74 +468,11 @@ extension ExpressionParser {
mutating func visitGlobalSet(wat: inout Wat) throws -> UInt32 {
return try globalIndex(wat: &wat)
}
mutating func visitI32Load(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 4)
mutating func visitLoad(_ load: Instruction.Load, wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: UInt32(load.naturalAlignment))
}
mutating func visitI64Load(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 8)
}
mutating func visitF32Load(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 4)
}
mutating func visitF64Load(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 8)
}
mutating func visitI32Load8S(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 1)
}
mutating func visitI32Load8U(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 1)
}
mutating func visitI32Load16S(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 2)
}
mutating func visitI32Load16U(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 2)
}
mutating func visitI64Load8S(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 1)
}
mutating func visitI64Load8U(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 1)
}
mutating func visitI64Load16S(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 2)
}
mutating func visitI64Load16U(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 2)
}
mutating func visitI64Load32S(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 4)
}
mutating func visitI64Load32U(wat: inout Wat) throws -> MemArg {
return try visitLoad(defaultAlign: 4)
}
mutating func visitI32Store(wat: inout Wat) throws -> MemArg {
return try visitStore(defaultAlign: 4)
}
mutating func visitI64Store(wat: inout Wat) throws -> MemArg {
return try visitStore(defaultAlign: 8)
}
mutating func visitF32Store(wat: inout Wat) throws -> MemArg {
return try visitStore(defaultAlign: 4)
}
mutating func visitF64Store(wat: inout Wat) throws -> MemArg {
return try visitStore(defaultAlign: 8)
}
mutating func visitI32Store8(wat: inout Wat) throws -> MemArg {
return try visitStore(defaultAlign: 1)
}
mutating func visitI32Store16(wat: inout Wat) throws -> MemArg {
return try visitStore(defaultAlign: 2)
}
mutating func visitI64Store8(wat: inout Wat) throws -> MemArg {
return try visitStore(defaultAlign: 1)
}
mutating func visitI64Store16(wat: inout Wat) throws -> MemArg {
return try visitStore(defaultAlign: 2)
}
mutating func visitI64Store32(wat: inout Wat) throws -> MemArg {
return try visitStore(defaultAlign: 4)
mutating func visitStore(_ store: Instruction.Store, wat: inout Wat) throws -> MemArg {
return try visitStore(defaultAlign: UInt32(store.naturalAlignment))
}
mutating func visitMemorySize(wat: inout Wat) throws -> UInt32 {
return try memoryIndex(wat: &wat)
Expand Down
Loading