Skip to content

BridgeJS: Standardize lift/lower pattern across Swift and JavaScript #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 24, 2025
Merged

BridgeJS: Standardize lift/lower pattern across Swift and JavaScript #423

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2699257
BridgeJS: Standardize lift/lower pattern across Swift and JavaScript
kateinoigakukun Aug 23, 2025
0df766e
ExportSwift: Remove unused className variable
kateinoigakukun Aug 23, 2025
e546582
BridgeJS: Add protocol-based intrinsic system
kateinoigakukun Aug 23, 2025
177be43
BridgeJS: Complete protocol-based lift/lower for ImportTS and _JSBrid…
kateinoigakukun Aug 23, 2025
9aad68d
BridgeJS: Provide default implementation for BridgeJS functions
kateinoigakukun Aug 23, 2025
7a31c5e
BridgeJS: Update test snapshot files
kateinoigakukun Aug 23, 2025
5f65738
BridgeJS: Repair PlayBridgeJS build
kateinoigakukun Aug 23, 2025
07c1ef7
BridgeJS: Clean up protocol definitions and documentation
kateinoigakukun Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ExportSwift: Remove unused className variable 
Clean up variable declaration in VariableDeclSyntax visitor.
  • Loading branch information
@kateinoigakukun
kateinoigakukun committed Aug 23, 2025
commit 0df766ef91d4de35bf402130908f26f853b4fd62
2 changes: 1 addition & 1 deletion Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ public class ExportSwift {

override func visit(_ node: VariableDeclSyntax) -> SyntaxVisitorContinueKind {
guard node.attributes.hasJSAttribute() else { return .skipChildren }
guard case .classBody(let className, let classKey) = state else {
guard case .classBody(_, let classKey) = state else {
diagnose(node: node, message: "@JS var must be inside a @JS class")
return .skipChildren
}
Expand Down
Loading