Skip to content

Make SwiftRuntime.memory constant property #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Make SwiftRuntime.memory constant property #375

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5909d5
Make SwiftRuntime.memory constant property
kateinoigakukun Jun 16, 2025
da88161
Reuse DataView as much as possible
kateinoigakukun Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Reuse DataView as much as possible
  • Loading branch information
@kateinoigakukun
kateinoigakukun committed Jun 16, 2025
commit da8816168e3664fad7e1905dd7e7460e3ef8cb46
5 changes: 3 additions & 2 deletions Runtime/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,8 +751,9 @@ export class SwiftRuntime {
throw new Error("threadChannel is not set in options given to SwiftRuntime. Please set it to request transferring objects.");
}
const broker = getMessageBroker(this.options.threadChannel);
const sendingObjects = decodeObjectRefs(sending_objects, sending_objects_count, this.getDataView());
const transferringObjects = decodeObjectRefs(transferring_objects, transferring_objects_count, this.getDataView());
const dataView = this.getDataView();
const sendingObjects = decodeObjectRefs(sending_objects, sending_objects_count, dataView);
const transferringObjects = decodeObjectRefs(transferring_objects, transferring_objects_count, dataView);
broker.request({
type: "request",
data: {
Expand Down