Skip to content

Resolve warnings #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Resolve warnings #266

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58e5b3c
Remove unnecessary `_JSFunctionProtocol`
kateinoigakukun Oct 15, 2024
2df9dad
Add nullability annotations to the C API
kateinoigakukun Oct 15, 2024
8975112
Suppress deprecation warning in JSTimer
kateinoigakukun Oct 15, 2024
b1b3024
Suppress retroactive conformance warnings in Swift 6
kateinoigakukun Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Suppress deprecation warning in JSTimer
  • Loading branch information
@kateinoigakukun
kateinoigakukun committed Oct 15, 2024
commit 89751127d7911eb6cada4e1b11d7fca0b5799f1f
4 changes: 4 additions & 0 deletions Sources/JavaScriptKit/BasicObjects/JSTimer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ public final class JSTimer {
case .oneshot(let closure):
closure.release()
case .repeating(let closure):
#if JAVASCRIPTKIT_WITHOUT_WEAKREFS
closure.release()
#else
break // no-op
#endif
}
}
}
Expand Down