Skip to content

Pass around a DataView instead of individual kind/payload fields #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-f1 wants to merge 4 commits into from
Closed

Pass around a DataView instead of individual kind/payload fields #24

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d72a4a8
Pass around a DataView on the JS side; cha nge memory layout for numbers
j-f1 Aug 2, 2020
27e7b24
Remove unused functions
j-f1 Aug 2, 2020
34c6d86
Add a switch fallthrough to reduce duplicated code
j-f1 Aug 2, 2020
a1cebd0
Fix docstring
j-f1 Aug 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a switch fallthrough to reduce duplicated code
  • Loading branch information
@j-f1
j-f1 committed Aug 2, 2020
commit 34c6d86d2a077ef99880f897cc6e6b3cef1bcddd
6 changes: 2 additions & 4 deletions Runtime/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ export class SwiftRuntime {
dataView.getUint32(payload2_ptr, true)
);
}
case JavaScriptValueKind.Object: {
case JavaScriptValueKind.Object:
case JavaScriptValueKind.Function: {
return this.heap.referenceHeap(dataView.getUint32(payload1_ptr, true))
}
case JavaScriptValueKind.Null: {
Expand All @@ -189,9 +190,6 @@ export class SwiftRuntime {
case JavaScriptValueKind.Undefined: {
return undefined
}
case JavaScriptValueKind.Function: {
return this.heap.referenceHeap(dataView.getUint32(payload1_ptr, true))
}
default:
throw new Error(`Type kind "${kind}" is not supported`)
}
Expand Down