Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer UInt(bitPattern:) for object id to guarantee uniqueness #219

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

kateinoigakukun
Copy link
Member

Close #218

@kateinoigakukun kateinoigakukun changed the title Prefer `UInt(bitPattern:)P for object id to guarantee uniqueness Prefer UInt(bitPattern:) for object id to guarantee uniqueness Dec 19, 2022
@kateinoigakukun kateinoigakukun requested a review from j-f1 December 19, 2022 15:02
Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kateinoigakukun kateinoigakukun merged commit dbf7a88 into main Dec 19, 2022
@kateinoigakukun kateinoigakukun deleted the katei/uint-bitpat branch December 19, 2022 15:04
@github-actions
Copy link

github-actions bot commented Dec 19, 2022

Time Change: -141ms (0%)

Total Time: 20,533ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 23ms -2ms (8%)
Serialization/JavaScript function call through Wasm import with int 22ms -1ms (6%)
View Unchanged
Test name Duration Change
Serialization/JavaScript function call from Swift 194ms -4ms (2%)
Serialization/Swift Int to JavaScript with assignment 515ms +3ms (0%)
Serialization/Swift Int to JavaScript with call 1,607ms -19ms (1%)
Serialization/JavaScript Number to Swift Int 529ms -6ms (1%)
Serialization/Swift String to JavaScript with assignment 591ms -6ms (1%)
Serialization/Swift String to JavaScript with call 1,709ms -49ms (2%)
Serialization/JavaScript String to Swift String 6,334ms -161ms (2%)
Object heap/Increment and decrement RC 8,987ms +107ms (1%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 4ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 7ms
Serialization/Write JavaScript string directly 4ms
Serialization/Call with JavaScript string directly 4ms

@sidepelican
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSClosure will be overriden from other closure
3 participants